Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimpleConsumer timeout behavior in get_messages (Issue 237) #238

Merged
merged 1 commit into from
Sep 23, 2014
Merged

Fix SimpleConsumer timeout behavior in get_messages (Issue 237) #238

merged 1 commit into from
Sep 23, 2014

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Sep 22, 2014

No description provided.

@wizzat
Copy link
Collaborator

wizzat commented Sep 22, 2014

I'm kinda curious why we're tracking the "timeout remaining" when "max time" is easily calculable via now() + seconds(timeout) and asking if now() > max_time?

@dpkp
Copy link
Owner Author

dpkp commented Sep 22, 2014

i think b/c that would require deeper refactoring within _get_messages , which takes a "timeout" parameter and which get_messages may call many times before returning

@wizzat
Copy link
Collaborator

wizzat commented Sep 22, 2014

Ok. We can put that off, but it's drop dead simple and a sure fire way to ensure this kind of bug never slips through again.

wizzat added a commit that referenced this pull request Sep 23, 2014
Fix SimpleConsumer timeout behavior in get_messages (Issue 237)
@wizzat wizzat merged commit 2e3d6db into dpkp:master Sep 23, 2014
@dpkp dpkp deleted the simple_consumer_get_messages_timeout branch June 10, 2015 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants